Generalize Write impl for Vec<u8> to Vec<u8, A> #82862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in the issue tracker for the wg-allocators working group[1], updating this implementation for allocator support was most likely just forgotten in the original PR. [1]: rust-lang/wg-allocators#86
TimDiekmann
approved these changes
Mar 7, 2021
|
@TimDiekmann I can't get you assigned manually either. I guess it's GitHub's side's issue. (According to https://docs.github.com/en/github/managing-your-work-on-github/assigning-issues-and-pull-requests-to-other-github-users#about-issue-and-pull-request-assignees "anyone who has commented" is assignable) |
|
Hmm, that's weird. Could you r=me anyway? |
|
Sure. @bors r=TimDiekmann rollup |
|
📌 Commit ab8995b has been approved by |
bors
added
the
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 8, 2021
…r=TimDiekmann Generalize Write impl for Vec<u8> to Vec<u8, A> As discussed in the [issue tracker for the wg-allocators working group][1], updating this impl for allocator support was most likely just forgotten previously. This PR fixes this. r? `@TimDiekmann` [1]: rust-lang/wg-allocators#86
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 8, 2021
…r=TimDiekmann Generalize Write impl for Vec<u8> to Vec<u8, A> As discussed in the [issue tracker for the wg-allocators working group][1], updating this impl for allocator support was most likely just forgotten previously. This PR fixes this. r? ``@TimDiekmann`` [1]: rust-lang/wg-allocators#86
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 8, 2021
…r=TimDiekmann Generalize Write impl for Vec<u8> to Vec<u8, A> As discussed in the [issue tracker for the wg-allocators working group][1], updating this impl for allocator support was most likely just forgotten previously. This PR fixes this. r? ```@TimDiekmann``` [1]: rust-lang/wg-allocators#86
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 8, 2021
…r=TimDiekmann Generalize Write impl for Vec<u8> to Vec<u8, A> As discussed in the [issue tracker for the wg-allocators working group][1], updating this impl for allocator support was most likely just forgotten previously. This PR fixes this. r? ````@TimDiekmann```` [1]: rust-lang/wg-allocators#86
This was referenced Mar 8, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 8, 2021
Rollup of 10 pull requests Successful merges: - rust-lang#82047 (bypass auto_da_alloc for metadata files) - rust-lang#82415 (expand: Refactor module loading) - rust-lang#82557 (Add natvis for Result, NonNull, CString, CStr, and Cow) - rust-lang#82613 (Remove Item::kind, use tagged enum. Rename variants to match) - rust-lang#82642 (Fix jemalloc usage on OSX) - rust-lang#82682 (Implement built-in attribute macro `#[cfg_eval]` + some refactoring) - rust-lang#82684 (Disable destination propagation on all mir-opt-levels) - rust-lang#82755 (Refactor confirm_builtin_call, remove partial if) - rust-lang#82857 (Edit ructc_ast_lowering docs) - rust-lang#82862 (Generalize Write impl for Vec<u8> to Vec<u8, A>) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the issue tracker for the wg-allocators working group, updating this impl for allocator support was most likely just forgotten previously. This PR fixes this.
r? @TimDiekmann